Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTD.EnhancedOutputMode & WheelAddon #92

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Mrcubix
Copy link
Contributor

@Mrcubix Mrcubix commented Mar 22, 2024

Updated OTD.EnhancedOutputMode for both 0.5 & 0.6.

OTD.EnhancedOutputMode wasn't handling touch reports with no points, which in turn, caused issues in plugins relying on those, like my currently WIP Touch gesture plugin.

Speaking of which (out of context), is here a preview of the pan gesture i'm working on for those interested:

20240322_221922.mp4

Anyways, some plugins also required to be initialized after the constructor as well as after the settings are injected,
so i added an interface for that purpose.

WheelAddon was also updated as it's dependent on OTD.EnhancedOutputMode.

@Mrcubix
Copy link
Contributor Author

Mrcubix commented Mar 29, 2024

Do not look at the first 3 characters of WheelAddon.json's hash.

@Mrcubix Mrcubix marked this pull request as ready for review March 29, 2024 20:03
@Mrcubix Mrcubix changed the title Update OTD.EnhancedOutputMode & WheelAddon Update OTD.EnhancedOutputMode & WheelAddon (+ OTD.LedSandbox's hash changed somehow) Mar 29, 2024
@Mrcubix Mrcubix marked this pull request as draft April 2, 2024 00:56
@Mrcubix Mrcubix closed this Apr 2, 2024
@Mrcubix
Copy link
Contributor Author

Mrcubix commented Apr 2, 2024

I didn't close this myself, but ok github

@Mrcubix Mrcubix reopened this Apr 2, 2024
@Mrcubix Mrcubix changed the title Update OTD.EnhancedOutputMode & WheelAddon (+ OTD.LedSandbox's hash changed somehow) Update OTD.EnhancedOutputMode & WheelAddon Apr 2, 2024
@Mrcubix Mrcubix marked this pull request as ready for review April 3, 2024 01:29
@InfinityGhost InfinityGhost merged commit 5bde654 into OpenTabletDriver:master Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants